search

aminography / PrimeDatePicker

PrimeDatePicker is a tool that provides picking a single day, multiple days, and a range of days.
Apache License 2.0
471 stars 52 forks source link

The BottomSheet has sharp edges instead of rounded one. #46

Closed rama-2402 closed 3 years ago

rama-2402 commented 3 years ago

The BottomSheet in sample app provided works fine and has rounded corners but for some reason using the library in the app i'm developing,

  1. Then BottomSheet is rectangle. When used dark theme/ dark background color it shows small white filled spaces. Screenshot_2021-01-24-19-52-42-37_3917da0d403222df0ac037cc35ea96cb

Is there any fix for this?

BTW Thank you so much for this library. I love every bit of it and how easy it is to impliment it!!

aminography commented 3 years ago

Hi @rama-2402, Thank you for reporting this issue. Could you please tell me what is the API level of the phone you are testing on? Does it occur on every device? You're welcome:))))

rama-2402 commented 3 years ago

Hi @aminography Thanks so much for responding. Yes! it is having this sharp edges on all the phones i have tested. I have tested it on Android 10, 9 Realme devices, also on API 22 on my android studio emulator. Everything works great except the corner radius.

aminography commented 3 years ago

NP :) It means that in your app theme, there is something that sets a white background for BottomSheets and we should find it. If it's possible to you, please show me the styles of the app which are related to the theme.

rama-2402 commented 3 years ago

Hi @aminography sorry for the delayed response. Here is my themes.xml file