search

aminomancer / uc.css.js

A dark indigo CSS theme for Firefox and a large collection of privileged scripts to add new buttons, menus, and behaviors and eliminate nuisances. The theme is similar to other userChrome stylesheets, but it's intended for use with an autoconfig loader like fx-autoconfig, since it uses JavaScript to implement its more functional features.
Other
329 stars 27 forks source link

Vertical tab pane not working completely as intended #14

Closed dewwdrp closed 2 years ago

dewwdrp commented 2 years ago

As the title says, the vertical tab pane is not working completely as intended. While it's pinned at full width it seems to work perfectly. Though when I unpin it, it no longer collapses as it's supposed to, the text of the tabs and the icons to not show the pane and to pin or unpin it do collapse, but the rest of the pane is still just sitting there.

It was working perfectly for me yesterday and last night, and I usually use the Release channel of Firefox so I did try it on Nightly just to make sure it wasn't a version difference causing the issue and it is not, I get the exact same results on the Nightly version as I do on the Release version.

It's not the worst thing in the world and I can cope without it obviously, but I thought it would be good to bring it to your attention.

Screenshot 2021-10-06 133746 Screenshot 2021-10-06 133656

aminomancer commented 2 years ago

Thanks for alerting me. Try version 1.5.0, lmk if you see any other problems. If you were curious, it's because --arrowpanel-menuitem-padding was changed into a vector value, apparently back in August. It was previously just defined as 8px, now it has a block component and an inline component, so its default value is 8px 8px. Since duskfox overrides the variable to just 6px I didn't notice this change. The script uses that variable to calculate the dimensions and positions of several elements. The calc() function expects variables to have a single value. It can't multiply vectors so when it sees something like calc(0 + 8px 8px) it just craps out and returns initial which yields these wacky results.

dewwdrp commented 2 years ago

Thank you! The version you just uploaded works for me perfectly! I find it odd that a value changed back in August didn't cause an issue until today but technology does as it pleases.

Again thank you for the quick response and fix, I don't use your theme itself, but I do use quite a few of your scripts and they really make firefox more convenient/useful for me. I know you wouldn't do it if it didn't help you in some way as well, or if you didn't get some joy out of it, but I do appreciate all the work and effort that I imagine you have to put into this, which in reality is probably more than my brain can fathom, lol. Hope you have a great day/night!