search

aminomancer / uc.css.js

A dark indigo CSS theme for Firefox and a large collection of privileged scripts to add new buttons, menus, behaviors and other opinionated features. The theme is similar to other userChrome stylesheets, but it's intended for use with an autoconfig loader like fx-autoconfig, since it uses JavaScript to implement its more functional features.
Other
337 stars 27 forks source link

PIP hotkey (ctrl+shift+]) isn't triggered when dealing with a video running inside an iframe #36

Closed ericpa06 closed 2 years ago

ericpa06 commented 2 years ago

So, I have been scratching my head with this one and I think it could be a interesting script. When you press the hotkey to set a video you are watching to picture-in-picture mode, Firefox doesn't set that video to pip mode if it is running inside an iframe, like this for instance:

https://old.reddit.com/r/curiousvideos/comments/t8w4si/palantir_they_are_watching_you/

Like, if you went to youtube and pressed that key combination, firefox would set that video to picture in picture. I think it's something they changed recently cause I remember that until very recently this used to work. I think it could be some security issue or something dealing with content on iframes or something?

The curious thing is that, if you go and click on the flying pip button that appears on the video, that content is set to picture-in-picture mode even if is running inside an iframe, like this here. So I think it's probably some issue with Firefox just not "detecting" what content you are watching or so? 1646730297

Maybe this could be a possible script, beside fixing this issue, the script could also allow user to choose other key combination to set the video you are watching to pip mode. Anyway, just an idea, thank you very much for your time..

ericpa06 commented 2 years ago

Update, I think firefox fixed this issues on the last editions.