[BUG] VerticalTabsPane Script broken on v107.0a1

aminomancer / uc.css.js

A dark indigo CSS theme for Firefox and a large collection of privileged scripts to add new buttons, menus, and behaviors and eliminate nuisances. The theme is similar to other userChrome stylesheets, but it's intended for use with an autoconfig loader like fx-autoconfig, since it uses JavaScript to implement its more functional features.

Other

326 stars 27 forks source link

[BUG] VerticalTabsPane Script broken on v107.0a1 #58

Closed AlbusPercivalDumbledore closed 9 months ago

AlbusPercivalDumbledore commented 1 year ago

Hey, MS!

VerticalTabsPane Script isn't working on v107.0a1

OS: Linux (Mint 20.3)

Tabs are visible only when the Pane is Pinned

Once Pane is unpinned, Tabs disappear, though the Pane keeps its place.

Also, scrolling doesn't work.

Could you please make it work again?

aminomancer commented 1 year ago

The layout folks are still working on the modern flexbox emulation changes, so I probably won't revisit this until they're done.

In the meantime, you can add this to userChrome.css

#browser {
  -moz-box-layout: revert !important;
}

AlbusPercivalDumbledore commented 1 year ago

The layout folks are still working on the modern flexbox emulation changes, so I probably won't revisit this until they're done.

In the meantime, you can add this to userChrome.css
#browser {
  -moz-box-layout: revert !important;
}

Ah, okay. Thanks!

AlbusPercivalDumbledore commented 1 year ago

I've been having another issue for quite sometime. I have over 600 Tabs open at present, and VerticalTabsPane lags considerably when showing (on hover) and hiding.

In contrast, I installed 'Tab Center Reborn' Extension a few days back, and its been noticeably faster.

Attaching a GIF showing the same. Could you please look into this too?

aminomancer commented 1 year ago

Have you changed the hover and hover out delays? There should be an option in the context menu if you right click the pin or toggle button.

Otherwise, performance isn't really my area of expertise. I'm working on a patch to add vertical tabs to Firefox so when that moves forward I'm sure there will be some optimizations. But at a glance, the one on the left is displayed in its own extension browser. Whereas mine is running in the main thread. So maybe that has something to do with it.

AlbusPercivalDumbledore commented 1 year ago

I hadn't; they were both set to 100. Though, now that I have set them both to 1, it feels slightly more responsive. I don't know, could be placebo effect :D

I'm working on a patch to add vertical tabs to Firefox so when that moves forward I'm sure there will be some optimizations.

Now, THAT'S AWESOME!

aminomancer commented 1 year ago

How is it working for you now?

AlbusPercivalDumbledore commented 9 months ago

How is it working for you now?

Hey, sorry saw this just now. I've been using v1.7.5, and its working wonderfully well :)