search

aminueza / terraform-provider-minio

Terraform provider for managing MinIO S3 buckets and IAM Users.
https://registry.terraform.io/providers/aminueza/minio
GNU Affero General Public License v3.0
243 stars 73 forks source link

Upgrade minio/aws dependencies #429

Closed BuJo closed 1 year ago

BuJo commented 1 year ago 
* Update indirect dependencies
* Tidy modules
* removes as of yet unused madm-go v2
BuJo commented 1 year ago

(!) github.com/minio/madmin-go/v2 changed the license from Apache 2.0 to AGPL. I'm not sure about that license combination, we should at least be careful.

BuJo commented 1 year ago

Currently used licenses in dependencies, checked via https://github.com/google/go-licenses (full licenses.csv appended.)

  14 Apache-2.0
   3 BSD-2-Clause
  13 BSD-3-Clause
  18 MIT
  19 MPL-2.0

So currently we're ok. All those can even be used in proprietary software.

Including the v2 madmin we would pull AGPL v3 into that. As far as I can tell e.g. this question on stackexchange, using the AGPL library would mean that we have to distribute the full binary under AGPL v3 as well. The source code can still be under the Apache-2.0 License.

According to hashicorp terraform documentation we would would not be eligible as a "partner" by distributing the provider under AGPL v3.

BuJo commented 1 year ago 
# github.com/minio/madmin-go
../../../scrap/go/pkg/mod/github.com/minio/madmin-go@v1.7.5/health.go:325:36: undefined: host.Warnings

This makes me lower the version of github.com/shirou/gopsutil/v3/host

This should be fixed (see https://github.com/shirou/gopsutil/releases in v3.22.12) but using any version after v3.22.9 still gives me that error..

the bot should upgrade that again, if it works.. we'll see.