search

aminueza / terraform-provider-minio

Terraform provider for managing MinIO S3 buckets and IAM Users.
https://registry.terraform.io/providers/aminueza/minio
GNU Affero General Public License v3.0
243 stars 73 forks source link

Add support for object locking in minio_s3_bucket resource. #453

Closed Eilyre closed 1 year ago

Eilyre commented 1 year ago

This PR implements the option to enable object locking with minio_s3_bucket resource type. There's a new option object_locking, that can be specified for these resources.

Default behavior did not change, and object locking defaults to false.

Reference

felladrin commented 1 year ago

Hi, @Eilyre! Thanks and congrats for your first contribution! A very welcome addition! I won't be able to go deep into testing it, but one of the other collaborators will come to review it soon. Could you please also update the tests to consider the new object_locking property?

Eilyre commented 1 year ago

Hello, thank you for the warm welcome! I completely forgot the tests, I'll do my best to fix them, but it'll take a bit of time, as currently the tests look more complicated than the application code - I'm fairly new to this.

Eilyre commented 1 year ago

I think I have the tests fixed now. There's still one test that fails locally - resource_minio_s3_bucket_notification_test.go:34 (TestS3BucketNotification_queue), but it also fails locally on the master branch without my changes.