Handle empty service account policy

aminueza / terraform-provider-minio

Terraform provider for managing MinIO S3 buckets and IAM Users.

https://registry.terraform.io/providers/aminueza/minio

GNU Affero General Public License v3.0

243 stars 73 forks source link

Handle empty service account policy #518

Closed ArataEM closed 1 year ago

ArataEM commented 1 year ago

This PR implements the following changes:

Prevents dropping of default policy by applying empty policy if none is set

Reference

Resolves: #517

BuJo commented 1 year ago

@ArataEM thanks for the contribution! Would it be ok for you to also implement a test-case for this? I'm not sure I fully understand how that behaviour would look like in the form of terraform resources.

ArataEM commented 1 year ago

Added a test case that fails if terraform service account resource has no policy, but service account in minio is created with policy inherited from target user.

felladrin commented 1 year ago

@BuJo, I approved the PR, considering the update from ArataEM and this review of dmaes, and will publish the change because I need to check if publishing new versions still works, now that the repo is under an organisation.