aminueza / terraform-provider-minio

Terraform provider for managing MinIO S3 buckets and IAM Users.
https://registry.terraform.io/providers/aminueza/minio
GNU Affero General Public License v3.0
243 stars 73 forks source link

Add name, description and expiration support for service accounts #594

Closed ribetm closed 3 weeks ago

ribetm commented 3 weeks ago

Add name, description and expiration support for service accounts

Changes

Allows setting 3 new attributes on service accounts:

Compatibility

All of these fields are optional, making it backward compatible.

Users may see a change on expiration from null to 1970-01-01T00:00:00Z (which are equivalent), but only if something else is updated. As far as I know there is no way around this, since Terraform considers null as untracked while Minio sees it as either epoch for creations, or as no change for updates.

Remarks

I've included argument validation matching Minio's API requirements:

Allowing invalid values to be sent to the API would throw relatively unclear errors, especially without verbose logging

ribetm commented 3 weeks ago

When I generated the docs with task generate-docs, it changed more than what I added. I only included what's related to my PR for now.

With a quick glance at the other changes, it may seem related to the new v3 schema

felladrin commented 3 weeks ago

Congrats on your first contribution to this repository, @ribetm! All clear! Let's merge and release it as v3.1.0! 🎉