aminya / CompileBot.jl

Automatic compilation for Julia packages
MIT License
17 stars 10 forks source link

Using Base.sort in order to avoid ambiguities #27

Closed casabre closed 3 years ago

casabre commented 3 years ago

There are package that are providing a sort implementation as well. This leads to the following error, e.g. with Redis.jl

WARNING: both Redis and Base export "sort"; uses of it in module Main must be qualified
ERROR: UndefVarError: sort not defined
codecov-io commented 3 years ago

Codecov Report

Merging #27 (aa3392d) into master (438d44b) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #27   +/-   ##
=======================================
  Coverage   72.53%   72.53%           
=======================================
  Files           7        7           
  Lines         415      415           
=======================================
  Hits          301      301           
  Misses        114      114           
Impacted Files Coverage Δ
src/snoop_bot.jl 75.34% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 76ebc54...aa3392d. Read the comment docs.