aminya / setup-cpp

Install all the tools required for building and testing C++/C projects.
Apache License 2.0
185 stars 27 forks source link

Intermittent warnings during installation (Ubuntu) #234

Open bjosv opened 6 months ago

bjosv commented 6 months ago

When setup-cpp prepares the apt-keys using gpg.. https://github.com/aminya/setup-cpp/blob/290824452986e378826155f3379d31bce8753d76/src/utils/setup/setupAptPack.ts#L190

the created files are not always available on disk when chmod is run https://github.com/aminya/setup-cpp/blob/290824452986e378826155f3379d31bce8753d76/src/utils/setup/setupAptPack.ts#L199

which produces annotations warnings in the run like:

Failed to add apt key via server keyserver.ubuntu.com: Error: Command failed with exit code 1: sudo 'chmod' '644' '/etc/apt/trusted.gpg.d/setup-cpp-ubuntu-archive.gpg'

This behavior is intermittent and probably dependent on how loaded the Github runner/machine is. Is this a know issue or would it be feasible to have a check that the file exists before performing the chmod?

Example logs:

2024-03-13T16:32:43.5134503Z gpg: keybox '/root/.gnupg/pubring.kbx' created
2024-03-13T16:32:43.5574851Z gpg: keyring '/etc/apt/trusted.gpg.d/setup-cpp-ubuntu-archive.gpg' created
2024-03-13T16:32:43.5769405Z gpg: keyring '/etc/apt/trusted.gpg.d/launchpad-toolchain.gpg' created
2024-03-13T16:32:44.5382292Z gpg: key 1E9377A2BA9EF27F: public key "Launchpad Toolchain builds" imported
2024-03-13T16:32:44.5466832Z gpg: key 1E9377A2BA9EF27F: "Launchpad Toolchain builds" not changed
2024-03-13T16:32:44.5467907Z gpg: Total number processed: 1
2024-03-13T16:32:44.5468560Z gpg:              unchanged: 1
2024-03-13T16:32:44.6642692Z gpg: Total number processed: 1
2024-03-13T16:32:44.6643420Z gpg:               imported: 1
2024-03-13T16:32:44.7015884Z gpg: key 3B4FE6ACC0B21F32: public key "Ubuntu Archive Automatic Signing Key (2012) <ftpmaster@ubuntu.com>" imported
2024-03-13T16:32:44.7017891Z gpg: Total number processed: 1
2024-03-13T16:32:44.7018903Z gpg:               imported: 1
2024-03-13T16:32:44.7027072Z gpg: key 3B4FE6ACC0B21F32: "Ubuntu Archive Automatic Signing Key (2012) <ftpmaster@ubuntu.com>" not changed
2024-03-13T16:32:44.7028461Z gpg: Total number processed: 1
2024-03-13T16:32:44.7029174Z gpg:              unchanged: 1
2024-03-13T16:32:44.7096843Z chmod: cannot access '/etc/apt/trusted.gpg.d/setup-cpp-ubuntu-archive.gpg': No such file or directory
2024-03-13T16:32:44.7098787Z gpg: key 40976EAF437D05B5: public key "Ubuntu Archive Automatic Signing Key <ftpmaster@ubuntu.com>" imported
2024-03-13T16:32:44.7108203Z gpg: Total number processed: 1
2024-03-13T16:32:44.7137810Z ##[warning]Failed to add apt key via server keyserver.ubuntu.com: Error: Command failed with exit code 1: sudo 'chmod' '644' '/etc/apt/trusted.gpg.d/setup-cpp-ubuntu-archive.gpg'
2024-03-13T16:32:44.7146153Z gpg:               imported: 1
2024-03-13T16:32:44.7156879Z gpg: key 40976EAF437D05B5: "Ubuntu Archive Automatic Signing Key <ftpmaster@ubuntu.com>" not changed
2024-03-13T16:32:44.7158035Z gpg: Total number processed: 1
2024-03-13T16:32:44.7158753Z gpg:              unchanged: 1

Upvote & Fund

@aminya is using Polar.sh so you can upvote and help fund this issue. The funding is received once the issue is completed & confirmed by you.

Thank you in advance for helping prioritize & fund our backlog!


Fund with Polar

aminya commented 6 months ago

The warnings should be addressed. Thanks for providing the details