search

amiq-consulting / fc4sc

A header only C++11 library for functional coverage
Apache License 2.0
36 stars 15 forks source link

Coverage GUI: "covered" verdict taken from "alias" attribute of coverpointBin? #21

Open cmarqu opened 4 years ago

cmarqu commented 4 years ago

It appears that the alias attribute of the coverpointBin element is taken as the value to derive the "covered" information from, not the coverageCount attribute of range/content (or sequence/content). What is the reason for that? It smells a bit like a workaround...

https://github.com/amiq-consulting/fc4sc/blob/35b80717092abef8f59af2bbd2f78d162a598ff5/tools/gui/fc4sc/js/bin.js#L30 https://github.com/amiq-consulting/fc4sc/blob/35b80717092abef8f59af2bbd2f78d162a598ff5/includes/fc4sc_bin.hpp#L198 https://github.com/amiq-consulting/fc4sc/blob/35b80717092abef8f59af2bbd2f78d162a598ff5/includes/fc4sc_bin.hpp#L216

amiq-consulting commented 4 years ago

Hi,

You are correct; it was the fastest way to implement the functionality. Since the cpp library will always generate the same value for the attributes coverageCount and alias, this doesn't matter for inspecting the coverage. This will be fixed.

Best Regards, Dragos Dospinescu