amir-jakoby / crawler-commons

Automatically exported from code.google.com/p/crawler-commons
0 stars 0 forks source link

[Sitemaps] Upgrade to JUnit v4 conventions #41

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Our JUnit works well.

But it uses JUnit v3 conventions.

I suggest upgrading to v4 conventions

What are the suggested changes?
The changes I suggest are as shown in the Junit github page here (Notes 
section):
https://github.com/junit-team/junit/wiki/Getting-started

The changes will include:
* @Test annotations
* Removing inheritance of TestCase and adding the annotation instead
* Adding expected annotation when expecting an exception

Original issue reported on code.google.com by avrah...@gmail.com on 21 May 2014 at 6:29

GoogleCodeExporter commented 8 years ago
Done

Patch is attached.

Original comment by avrah...@gmail.com on 21 May 2014 at 7:22

Attachments:

GoogleCodeExporter commented 8 years ago
Committed revision 128
Thank you Avi.

Original comment by lewis.mc...@gmail.com on 29 May 2014 at 9:02

GoogleCodeExporter commented 8 years ago

Original comment by avrah...@gmail.com on 12 Jul 2014 at 8:24