amir1376 / ab-download-manager

A Download Manager that speeds up your downloads
https://abdownloadmanager.com
Apache License 2.0
3.11k stars 155 forks source link

Bug : open folder not working #164

Open Mahantor opened 2 weeks ago

Mahantor commented 2 weeks ago

The option to open the folder after the download is complete does not work I am using the latest portable version Screenshot 2024-11-01 225717

amir1376 commented 2 weeks ago

Hi. what version you are using in what platform?

Mahantor commented 2 weeks ago

Hi. what version you are using in what platform?

1.4.1 portable

amir1376 commented 2 weeks ago

This is not 1.4.1 nor 1.4.0. because I changed the "Folder" to "Open Folder" and "File" to "Open File" since 1.4.0 ! I think you have two versions in your system. you can see the running version by going to Help > About

the problem with open folder in linux was fixed a few versions ago

Mahantor commented 2 weeks ago

https://github.com/user-attachments/assets/7726c6aa-9e83-427a-8abd-24d830f03da4

amir1376 commented 1 week ago

when you are pressing on "Open Folder" please open the home screen too. if there is an error then a notification will appear over there btw is "Open File" works for you?

Mahantor commented 1 week ago

https://github.com/user-attachments/assets/17e1e4f9-bb4d-4803-9de7-6868853771a9

amir1376 commented 1 week ago

That's weird! I am using this command to open the downloaded file's folder

cmd /c explorer.exe /select, <file-path>

the <file-path> is an absolute path of the downloaded file for example C:/users/Downloasds/ABDM/Compressed/archive.rar

You can test it manually in your terminal (cmd)

if it doesn't work try this instead. let see if it prints some errors in the terminal?

explorer.exe /select, <file-path>

I think there is a problem with these commands in your system.

Mahantor commented 1 week ago

I understood why it happens The problem was that C:\Windows and C:\Windows\System32 were not defined for the path variable in Environment Variables. In my opinion, to avoid this problem, it is better to replace the command cmd /c explorer.exe /select, with the this command C:\Windows\explorer.exe /select, in this case even if the paths are not defined correctly, select file will be done correctly

amir1376 commented 1 week ago

Did you manually remove those in PATH ?

Mahantor commented 1 week ago

no

amir1376 commented 1 week ago

I saw that almost all programs act like this (depend on PATH for accessing cmd and explorer). this is weird that these directories are not set for you!

BTW thanks for mentioning that.