amir20 / dozzle

Realtime log viewer for docker containers.
https://dozzle.dev/
MIT License
5.7k stars 287 forks source link

Support dozzle agent in Unraid #3223

Closed sefininio closed 2 weeks ago

sefininio commented 3 weeks ago

Describe the feature you would like to see

Hello @amir20

When installing the Dozzle container on Unraid, I can add the agent port and DOZZLE_HOSTNAME variables, but there is no way (that I can find) to provide the command: agent part to make the container operate as an agent.

image

Any ideas?

Describe how you would like to see this feature implemented

No response

Describe any alternatives you've considered

No response

sefininio commented 3 weeks ago

FYI - as a work around, I created the container as agent inside a dedicated docker-compose within unraid. So it is possible as a work around, albeit not in a very obvious way.

Maybe creating a new Unraid dozzle recipe as an agent?

amir20 commented 3 weeks ago

I could easily solve this by creating an env like DOZZLE_MODE=agent.

Does Unraid really not have a way to overwrite the command?

sefininio commented 3 weeks ago

I think the env is far better than the command option anyway, but to the point of Unraid - as far as I can see, there is no way other than creating a compose stack 🤷

amir20 commented 3 weeks ago

https://github.com/amir20/dozzle/pull/3226 should fix this. You can try it with amir20/dozzle:pr-3226. I'd want to update the documentation before releasing. Let me know if it works out.

amir20 commented 3 weeks ago

I wanted to try Unraid and play around with it. It doesn't look to be that simple.

sefininio commented 3 weeks ago

Thanks for the quick response! That doesn't seem to work, though.

I tried on a different server (Unraid wasn't accessible to me just now), with:

  dozzle:
    container_name: dozzle
    image: amir20/dozzle:pr-3226
    restart: always
    environment:
      - tailSize=1000
      - DOZZLE_HOSTNAME=family-z2m
      - DOZZLE_MODE=agent
    volumes:
      - /var/run/docker.sock:/var/run/docker.sock
    ports:
      - 9095:7007

And the dozzle UI marked it as offline.

amir20 commented 3 weeks ago

Hmm I may have nil pointer error. One minute. Let me see if I can debug.

amir20 commented 3 weeks ago

Hmmmmm I see. So with agent command you could have overwritten the port at :7007. But with DOZZLE_MODE that functionality won't exist any more since it's not a subcommand. I fixed it to just hardcode to 7007. I think that's good enough. I think it would be hard to have an env variable behave like a sub command.

Give a try now. Make sure you docker pull the latest.

amir20 commented 3 weeks ago

Ping @sefininio. Would like to merge if this works.

sefininio commented 3 weeks ago

Oh. Haven't had the chance to test. Will try to get to it today. Sorry for the delay... 🙏

amir20 commented 2 weeks ago

Looks like this PR breaks other things. The more I think about it, I don't think I want to have two separate entry points.

I am going to close this as not going to do. Seems like there is a workaround to use compose file so less urgent.

sefininio commented 2 weeks ago

Yeah I agree the workaround is probably the best. I'm sorry I didn't get the chance to test it, the last week have been hectic...

On Tue, Aug 27, 2024, 23:56 Amir Raminfar @.***> wrote:

Closed #3223 https://github.com/amir20/dozzle/issues/3223 as not planned.

— Reply to this email directly, view it on GitHub https://github.com/amir20/dozzle/issues/3223#event-14034953479, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZXKSQ45DY67ZVWW5GS73TZTTRYFAVCNFSM6AAAAABM7XT6HSVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJUGAZTIOJVGM2DOOI . You are receiving this because you were mentioned.Message ID: @.***>