github-actions[bot]
commented
2 years ago Terraform Format and Style 🖌success
Terraform Initialization ⚙️success
Terraform Validation 🤖success
Terraform Plan 📖success
Show Plan
``` terraform Running plan in Terraform Cloud. Output will stream here. Pressing Ctrl-C will stop streaming the logs, but will not stop the plan running remotely. Preparing the remote plan... The remote workspace is configured to work with configuration at /terraform relative to the target repository. Terraform will upload the contents of the following directory, excluding files or directories as defined by a .terraformignore file at /home/runner/work/amirainvest_com/amirainvest_com/.terraformignore (if it is present), in order to capture the filesystem context the remote workspace expects: /home/runner/work/amirainvest_com/amirainvest_com To view this run in a browser, visit: https://app.terraform.io/app/Amirainvest/Production/runs/run-SxjMwZiU5GdmNArS Waiting for the plan to start... Terraform v1.1.6 on linux_amd64 Configuring remote state backend... Initializing Terraform configuration... module.market_data_eod_updates_lambda.aws_cloudwatch_event_rule.working_day_market_close: Refreshing state... [id=prod-market-data-eod-updates_working_day_market_close] module.brokerage_data_lambda.aws_iam_policy.dynamo_read_write: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-brokerage-data-sqs-consumer-lambda-dynamo-read-write] module.market_data_realtime_updates_lambda.module.market_data_realtime_updates_lambda.aws_kms_key.logs: Refreshing state... [id=217e86b1-c5b3-4550-a160-240f1f5c0a5d] module.brokerage_data_lambda.aws_iam_policy.sqs_read_write: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-brokerage-data-sqs-consumer-lambda-sqs-read-write] module.market_data_realtime_updates_lambda.aws_cloudwatch_event_rule.working_day_every_minute_cron: Refreshing state... [id=prod-market-data-realtime-updates_working_day_every_minute_cron] module.brokerage_data_lambda.module.brokerage_data_lambda.aws_kms_key.logs: Refreshing state... [id=95cd14b6-48e0-4601-b40e-76f739924927] module.backend_api.aws_ecs_cluster.api: Refreshing state... [id=arn:aws:ecs:us-east-1:903791206266:cluster/api] module.data_imports.aws_ecr_repository.lambda: Refreshing state... [id=amirainvest_com/data_imports.lambda] module.brokerage_data_lambda.aws_sqs_queue.brokerage-data-deadletter: Refreshing state... [id=https://sqs.us-east-1.amazonaws.com/903791206266/prod-brokerage-data-deadletter] module.brokerage_data_lambda_base.aws_ecr_repository.brokerage_data_lambda: Refreshing state... [id=amirainvest_com/brokerage.lambda] module.brokerage_data_lambda.aws_dynamodb_table.brokerage_users: Refreshing state... [id=brokerage_users] module.data_imports.module.lambda_data_loader_consumer_expedited.aws_iam_policy.sqs_read_delete: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-data_imports-sqs-data-consumer-expedited-lambda-sqs-read-delete] module.data_imports.aws_sqs_queue.data-imports-deadletters: Refreshing state... [id=https://sqs.us-east-1.amazonaws.com/903791206266/prod-data-imports-deadletters] module.backend_api.aws_s3_bucket.amira-user-profile-photos-holding: Refreshing state... [id=prod-amira-user-profile-photos-holding] aws_vpc.elastic-beanstalk: Refreshing state... [id=vpc-bb2d45c6] module.backend_api.aws_sqs_queue.photo-processing-deadletter: Refreshing state... [id=https://sqs.us-east-1.amazonaws.com/903791206266/prod-photo-processing-deadletter] module.market_data_eod_updates_lambda.module.market_data_eod_updates_lambda.aws_kms_key.logs: Refreshing state... [id=14e26d7b-a836-4fea-9a28-3a2926b3ba17] module.backend_api.aws_s3_bucket.amira-user-profile-photos: Refreshing state... [id=prod-amira-user-profile-photos] module.backend_api.aws_ecr_repository.backend_amirainvest_com: Refreshing state... [id=amirainvest_com/backend_amirainvest_com] module.data_imports.aws_sqs_queue.expedited-data-imports-deadletters: Refreshing state... [id=https://sqs.us-east-1.amazonaws.com/903791206266/prod-expedited-data-imports-deadletters] module.networking.aws_vpc.public-private: Refreshing state... [id=vpc-004c212060d1b7976] module.data_imports.module.lambda_data_loader_consumer.module.lambda.aws_kms_key.logs: Refreshing state... [id=78ac0baa-2101-44aa-ac40-4f46dad4e4e4] module.backend_api.aws_s3_bucket.amira-post-photos: Refreshing state... [id=prod-amira-post-photos] module.data_imports.module.lambda_data_loader_consumer.aws_iam_policy.sqs_read_delete: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-data_imports-sqs-data-consumer-lambda-sqs-read-delete] module.data_imports.module.lambda_data_loader_producer.aws_iam_policy.write: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-data_imports-sqs-data-producer-lambda-sqs-write] module.data_imports.module.lambda_data_loader_producer.module.lambda_base.aws_kms_key.logs: Refreshing state... [id=2d7a58d2-dfeb-4220-a42f-be6ef9ce6058] module.backend_api.aws_s3_bucket.amira-post-photos-holding: Refreshing state... [id=prod-amira-post-photos-holding] module.data_imports.module.lambda_data_loader_consumer_expedited.module.lambda.aws_kms_key.logs: Refreshing state... [id=c307942f-e774-4eaf-b85e-5d609b619056] module.market_data_lambda_base.aws_ecr_repository.market_data_lambda: Refreshing state... [id=amirainvest_com/market_data.lambda] module.brokerage_data_lambda.module.brokerage_data_lambda.aws_cloudwatch_log_group.lambda: Refreshing state... [id=/aws/lambda/prod-brokerage-data-sqs-consumer] module.market_data_realtime_updates_lambda.module.market_data_realtime_updates_lambda.aws_cloudwatch_log_group.lambda: Refreshing state... [id=/aws/lambda/prod-market-data-realtime-updates] module.backend_api.aws_ecs_cluster_capacity_providers.api: Refreshing state... [id=api] module.brokerage_data_lambda.aws_sqs_queue.brokerage-data: Refreshing state... [id=https://sqs.us-east-1.amazonaws.com/903791206266/prod-brokerage-data] module.market_data_eod_updates_lambda.module.market_data_eod_updates_lambda.aws_cloudwatch_log_group.lambda: Refreshing state... [id=/aws/lambda/prod-market-data-eod-updates] module.backend_api.aws_sqs_queue.photo-processing: Refreshing state... [id=https://sqs.us-east-1.amazonaws.com/903791206266/prod-photo-processing] module.data_imports.aws_sqs_queue.data-imports: Refreshing state... [id=https://sqs.us-east-1.amazonaws.com/903791206266/prod-data-imports] module.data_imports.aws_sqs_queue.expedited-data-imports: Refreshing state... [id=https://sqs.us-east-1.amazonaws.com/903791206266/prod-expedited-data-imports] module.data_imports.module.lambda_data_loader_consumer.module.lambda.aws_cloudwatch_log_group.lambda: Refreshing state... [id=/aws/lambda/prod-data_imports-sqs-data-consumer] module.data_imports.module.lambda_data_loader_producer.module.lambda_base.aws_cloudwatch_log_group.lambda: Refreshing state... [id=/aws/lambda/prod-data_imports-sqs-data-producer] module.data_imports.module.lambda_data_loader_consumer_expedited.module.lambda.aws_cloudwatch_log_group.lambda: Refreshing state... [id=/aws/lambda/prod-data_imports-sqs-data-consumer-expedited] module.backend_api.aws_ecs_task_definition.api-public-ecs-task-definition: Refreshing state... [id=prod-api-public-ecs-task-definition] module.brokerage_data_lambda.module.brokerage_data_lambda.aws_iam_policy.log-writing: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-brokerage-data-sqs-consumer-lambda-log-writing] module.backend_api.aws_s3_bucket_request_payment_configuration.amira-user-profile-photos-holding: Refreshing state... [id=prod-amira-user-profile-photos-holding] module.market_data_realtime_updates_lambda.module.market_data_realtime_updates_lambda.aws_iam_policy.log-writing: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-market-data-realtime-updates-lambda-log-writing] module.backend_api.aws_s3_bucket_server_side_encryption_configuration.amira-user-profile-photos-holding: Refreshing state... [id=prod-amira-user-profile-photos-holding] module.backend_api.aws_s3_bucket_acl.amira-user-profile-photos-holding: Refreshing state... [id=prod-amira-user-profile-photos-holding,private] module.market_data_eod_updates_lambda.module.market_data_eod_updates_lambda.aws_iam_policy.log-writing: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-market-data-eod-updates-lambda-log-writing] module.backend_api.aws_s3_bucket_versioning.amira-user-profile-photos-holding: Refreshing state... [id=prod-amira-user-profile-photos-holding] module.data_imports.module.lambda_data_loader_consumer.module.lambda.aws_iam_policy.log-writing: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-data_imports-sqs-data-consumer-lambda-log-writing] module.backend_api.aws_s3_bucket_acl.amira-post-photos: Refreshing state... [id=prod-amira-post-photos,private] module.data_imports.module.lambda_data_loader_producer.module.lambda_base.aws_iam_policy.log-writing: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-data_imports-sqs-data-producer-lambda-log-writing] module.backend_api.aws_s3_bucket_acl.amira-user-profile-photos: Refreshing state... [id=prod-amira-user-profile-photos,private] module.backend_api.aws_s3_bucket_versioning.amira-user-profile-photos: Refreshing state... [id=prod-amira-user-profile-photos] module.backend_api.aws_s3_bucket_versioning.amira-post-photos: Refreshing state... [id=prod-amira-post-photos] module.backend_api.aws_s3_bucket_server_side_encryption_configuration.amira-post-photos: Refreshing state... [id=prod-amira-post-photos] module.backend_api.aws_s3_bucket_server_side_encryption_configuration.amira-user-profile-photos: Refreshing state... [id=prod-amira-user-profile-photos] module.backend_api.aws_s3_bucket_request_payment_configuration.amira-user-profile-photos: Refreshing state... [id=prod-amira-user-profile-photos] module.backend_api.aws_s3_bucket_request_payment_configuration.amira-post-photos: Refreshing state... [id=prod-amira-post-photos] module.backend_api.aws_s3_bucket_server_side_encryption_configuration.amira-post-photos-holding: Refreshing state... [id=prod-amira-post-photos-holding] module.backend_api.aws_s3_bucket_acl.amira-post-photos-holding: Refreshing state... [id=prod-amira-post-photos-holding,private] module.backend_api.aws_s3_bucket_request_payment_configuration.amira-post-photos-holding: Refreshing state... [id=prod-amira-post-photos-holding] module.backend_api.aws_s3_bucket_versioning.amira-post-photos-holding: Refreshing state... [id=prod-amira-post-photos-holding] module.data_imports.module.lambda_data_loader_consumer_expedited.module.lambda.aws_iam_policy.log-writing: Refreshing state... [id=arn:aws:iam::903791206266:policy/service-role/prod-data_imports-sqs-data-consumer-expedited-lambda-log-writing] module.brokerage_data_lambda.module.brokerage_data_lambda.aws_iam_role.lambda: Refreshing state... [id=prod-brokerage-data-sqs-consumer-lambda] module.market_data_realtime_updates_lambda.module.market_data_realtime_updates_lambda.aws_iam_role.lambda: Refreshing state... [id=prod-market-data-realtime-updates-lambda] module.market_data_eod_updates_lambda.module.market_data_eod_updates_lambda.aws_iam_role.lambda: Refreshing state... [id=prod-market-data-eod-updates-lambda] module.data_imports.module.lambda_data_loader_producer.module.lambda_base.aws_iam_role.lambda: Refreshing state... [id=prod-data_imports-sqs-data-producer-lambda] module.data_imports.module.lambda_data_loader_consumer.module.lambda.aws_iam_role.lambda: Refreshing state... [id=prod-data_imports-sqs-data-consumer-lambda] module.data_imports.module.lambda_data_loader_consumer_expedited.module.lambda.aws_iam_role.lambda: Refreshing state... [id=prod-data_imports-sqs-data-consumer-expedited-lambda] module.networking.aws_subnet.private-1: Refreshing state... [id=subnet-031bdf1a786694a68] module.networking.aws_subnet.private-2: Refreshing state... [id=subnet-05a45c47337ce649e] module.networking.aws_subnet.public-2: Refreshing state... [id=subnet-073ca0b0ec5005fe9] module.networking.aws_subnet.private-3: Refreshing state... [id=subnet-0bb4370ccc2df1e3e] module.networking.aws_subnet.public-1: Refreshing state... [id=subnet-0dca5ef95d08f2d2c] module.networking.aws_subnet.public-3: Refreshing state... [id=subnet-09f2a12a119bcc599] module.backend_api.aws_security_group.api-public-service: Refreshing state... [id=sg-04c6dcf097a53b73c] module.market_data_realtime_updates_lambda.module.market_data_realtime_updates_lambda.aws_security_group.lambda: Refreshing state... [id=sg-08ef4427aec81f4bc] module.brokerage_data_lambda.module.brokerage_data_lambda.aws_security_group.lambda: Refreshing state... [id=sg-096cd128173fa28d0] module.market_data_eod_updates_lambda.module.market_data_eod_updates_lambda.aws_security_group.lambda: Refreshing state... [id=sg-0c5690a37e13700d2] module.data_imports.module.lambda_data_loader_producer.module.lambda_base.aws_security_group.lambda: Refreshing state... [id=sg-0150ee5e667365ae1] module.data_imports.module.lambda_data_loader_consumer_expedited.module.lambda.aws_security_group.lambda: Refreshing state... [id=sg-0edb93a49368e9eb0] module.data_imports.module.lambda_data_loader_consumer.module.lambda.aws_security_group.lambda: Refreshing state... [id=sg-063a7a163ea748422] module.backend_api.aws_ecs_service.api-public-service: Refreshing state... [id=arn:aws:ecs:us-east-1:903791206266:service/api/prod-api-public-service] module.brokerage_data_lambda.module.brokerage_data_lambda.aws_lambda_function.main: Refreshing state... [id=prod-brokerage-data-sqs-consumer] module.market_data_eod_updates_lambda.module.market_data_eod_updates_lambda.aws_lambda_function.main: Refreshing state... [id=prod-market-data-eod-updates] module.market_data_realtime_updates_lambda.module.market_data_realtime_updates_lambda.aws_lambda_function.main: Refreshing state... [id=prod-market-data-realtime-updates] module.data_imports.module.lambda_data_loader_producer.module.lambda_base.aws_lambda_function.main: Refreshing state... [id=prod-data_imports-sqs-data-producer] module.data_imports.module.lambda_data_loader_consumer_expedited.module.lambda.aws_lambda_function.main: Refreshing state... [id=prod-data_imports-sqs-data-consumer-expedited] module.data_imports.module.lambda_data_loader_consumer.module.lambda.aws_lambda_function.main: Refreshing state... [id=prod-data_imports-sqs-data-consumer] module.brokerage_data_lambda.aws_lambda_event_source_mapping.sqs-to-brokerage-data-sqs-consumer-lambda: Refreshing state... [id=23af04aa-8c2d-4965-827c-195bd556a550] module.market_data_realtime_updates_lambda.aws_lambda_permission.allow_working_day_every_minute_cron_to_call_market_data_realtime_updates_lambda: Refreshing state... [id=AllowExecutionFromCloudWatch] module.market_data_realtime_updates_lambda.aws_cloudwatch_event_target.working_day_every_minute_cron: Refreshing state... [id=prod-market-data-realtime-updates_working_day_every_minute_cron-terraform-20220119175437204000000001] module.market_data_eod_updates_lambda.aws_cloudwatch_event_target.working_day_market_close_cron: Refreshing state... [id=prod-market-data-eod-updates_working_day_market_close-terraform-20220212234456322700000001] module.data_imports.module.lambda_data_loader_consumer_expedited.aws_lambda_event_source_mapping.sqs-to-consumer-lambda: Refreshing state... [id=77642441-2a8e-4649-857a-10d820608e64] module.market_data_eod_updates_lambda.aws_lambda_permission.allow_working_day_market_close_cron_to_call_market_data_eod_updates_lambda: Refreshing state... [id=AllowExecutionFromCloudWatch] module.data_imports.module.lambda_data_loader_consumer.aws_lambda_event_source_mapping.sqs-to-consumer-lambda: Refreshing state... [id=4af43d97-439d-43a3-b50b-34cdfdf40ad4] No changes. Your infrastructure matches the configuration. Terraform has compared your real infrastructure against your configuration and found no differences, so no changes are needed. ```Pusher: @jlancaster7, Action: pull_request
Please don't make fun of my code, I'm not a real dev hides under desk.. also, I'm disappointed with Githubs lack of emoji's :(
Joking aside, the main changes were updates to the sorting mechanism in "get_discovery_feed" and then how we paginate across the feed/get endpoint. I changed it to 'created_at' vs 'id', because the id in theory doesn't necessarily correspond to when something was posted, and more corresponds to when we a given post was uploaded by our system. I'm aware there could be collisions in using created_at, but as our datetimes record down to the millisecond, its pretty unlikely.
The second major change is adding an ability to search posts with a company ticker by submitting a ticker through 'company_ticker'. An issue that came up was that certain tickers can also be words that people use in normal conversations (U, A, AN, AM, HE) end up being returned if we just search on ticker. The other option is to only return tickers that have '$' in front of it, as is the standard on Twitter but not necessarily on other platforms. My temporary solution, as I didn't want to just search with '$' concat'd onto the ticker (eg. $U), was to check if the ticker submitted is in our list of common 'stopwords' and if it is, to only search the ticker with the '$' concat'd onto the ticker. If its not in our list of stopwords, then to search it with and without the '$' concat'd onto it. I would have make my list of stopwords its own table.. but tbh.. I don't know how to use alembic and create a new table in our environment.