search

amirchev / OBS-Lyrics

Manage and display lyrics to any text source in your OBS scene.
Apache License 2.0
27 stars 17 forks source link

Dc strato #22

Closed DCStrato closed 3 years ago

DCStrato commented 3 years ago

New Monitor.htm file is being updated in the directory with songs. This can be installed in a OBS Browser dock to monitor Current Song: Current Lyric: Next Lyric: and Next Song:

amirchev commented 3 years ago

Hey, would it possible to update the Readme to explain how to use the monitor.htm file? Also, instead of having two .lua files, could you leave only the one that you think is best?

DCStrato commented 3 years ago

Yes to both

amirchev commented 3 years ago

Hey, the lyrics text keeps blinking while using this version. Everything works fine but the crossfade. :(

amirchev commented 3 years ago

I did a little digging through the commit history of your #22 pull request. I found that this commit: ee87469c148039a6966b26901c93628ed9bdf517 actually works as expected. Somewhere down the line, the code was ruined and created the blinking when paging bug again. Maybe if you revert to that commit and make the changes again, we'll be ok?

DCStrato commented 3 years ago

Ok I will check it out. Thanks

DCStrato commented 3 years ago

I am planning to use this version in service tomorrow. Hopefully all will go well, but nothing like going live to find issues!

If your configurations all work in addition to mine, we might be good. I have a large inventory of song lyrics I might contribute as examples that could download with the code. I will go over each early next week and confirm they all still work.

amirchev commented 3 years ago

Hey @wzaggle, I did a test run and noticed that if you hide the lyrics using the "Hide/Show Lyrics" button, you cannot unhide them using that button. You have to press "Next lyric" button and then lyrics will show.

amirchev commented 3 years ago

I looked a little through it but am having a hard time following the code :(

DCStrato commented 3 years ago

Every time I get back to the Lyrics Code it takes me a few hours to figure it out again. It is a big mental model for how it all works. Cleaner now than before. Some things were working because of what were really bugs. Mostly the fade options working with non-fade, and source loads working with pre-prepared lists.

I believe I got the show/hide fixed as long as it didn’t break something else, which is what typically happens.

WZ

From: Aleksandr Mirchev @.> Sent: Friday, August 27, 2021 8:36 PM To: amirchev/OBS-Lyrics @.> Cc: DCStrato @.>; Author @.> Subject: Re: [amirchev/OBS-Lyrics] Dc strato (#22)

Hey @wzaggle https://github.com/wzaggle , I did a test run and noticed that if you hide the lyrics using the "Hide/Show Lyrics" button, you cannot unhide them using that button. You have to press "Next lyric" button and then lyrics will show.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amirchev/OBS-Lyrics/pull/22#issuecomment-907554217 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ASIM4CXQ6RC6ETFM5ATGH6DT7BDSPANCNFSM5BPKH4RQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .