search

amireh / happypack

Happiness in the form of faster webpack build times.
MIT License
4.24k stars 124 forks source link

options validator still supports loaders.path, but is it really still valid? #199

Closed jedwards1211 closed 6 years ago

jedwards1211 commented 6 years ago

I noticed that https://github.com/amireh/happypack/blob/master/lib/HappyPlugin.js#L54 still allows

new HappyPlugin({
  loaders: [{
    path: 'babel-loader',
  }]
})

But it seems like my files don't get babelified unless I change that to loader: 'babel-loader'. I'm guessing that support for path was dropped but someone forgot to update the options validator accordingly. Amirite?

jedwards1211 commented 6 years ago

I'd recommend using flow and flow-runtime to validate the options.

amireh commented 6 years ago

I'm fairly confident this has not changed as it would have been a pretty breaking change. The code hasn't changed, and if such a change did go through, most of our projects would break.

Please verify things are OK on your end, if you're still having issues, paste the full config file and log output.

amireh commented 6 years ago

Closing this since there hasn't been any activity, feel free to open another ticket if you're still seeing the problem. Thanks!