search

amireh / happypack

Happiness in the form of faster webpack build times.
MIT License
4.24k stars 124 forks source link

Update Faq wrt webpack 2/3 #209

Closed tarjei closed 6 years ago

tarjei commented 6 years ago

I can see that I am changing something that might imply changed support conditions for webpack 2 - but isn't that the defacto state of happypack?

If you just look at the github repo you get the impression that the latest version of webpack is 3.0.3 and not 4.0.1 and that 4.x is in beta still. That is why I am proposing this change and the other PR.

codecov-io commented 6 years ago

Codecov Report

Merging #209 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #209   +/-   ##
=======================================
  Coverage   94.53%   94.53%           
=======================================
  Files          25       25           
  Lines         713      713           
=======================================
  Hits          674      674           
  Misses         39       39

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e615555...0afbd96. Read the comment docs.

amireh commented 6 years ago

Yeah that looks fine to me. We should be past any webpack-2 exclusive issues by now.

Thanks!