search

amireh / happypack

Happiness in the form of faster webpack build times.
MIT License
4.24k stars 124 forks source link

revisit and fix the example runner #250

Closed amireh closed 5 years ago

amireh commented 5 years ago

fixes GH-248

webpack was having issues resolving node packages when "node_modules" isn't reachable from the source directory, that's because we're installing node packages in a different folder tree so that we can test against multiple webpack versions

examples/foo
├── lib
└── versions
    └── 1
        └── node_modules

so now the "node_modules" of the current webpack target is symlinked into the example base directory

anyway, the example runner has been revisited altogether to provide a more consistent behavior and better interface and output. Usage is now documented in HACKING.md as well as in examples/build-all.sh

codecov-io commented 5 years ago

Codecov Report

Merging #250 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #250   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          25       25           
  Lines         733      733           
=======================================
  Hits          695      695           
  Misses         38       38

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6549ad0...53bb7ad. Read the comment docs.