search

amireh / happypack

Happiness in the form of faster webpack build times.
MIT License
4.23k stars 124 forks source link

【hard-source-webpack-plugin has 5 arguments】happypack can't support #251

Closed FengXianGuo closed 5 years ago

FengXianGuo commented 5 years ago

throw signature changed error when running hard-source-webpack-plugin with happypack

here the issues: https://github.com/mzgoddard/hard-source-webpack-plugin/issues/326 https://github.com/mzgoddard/hard-source-webpack-plugin/issues/439

codecov-io commented 5 years ago

Codecov Report

Merging #251 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #251   +/-   ##
=======================================
  Coverage   94.81%   94.81%           
=======================================
  Files          25       25           
  Lines         733      733           
=======================================
  Hits          695      695           
  Misses         38       38
Impacted Files Coverage Δ
lib/WebpackUtils.js 94.36% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3f3fed2...4da69da. Read the comment docs.

amireh commented 5 years ago

Thanks for the contribution! Let me pull it down and run the examples.

amireh commented 5 years ago

Confirmed that the fix works. I'll be following up with a patch that adds an example of hard-source targeting webpack 3 and 4 to guard against future regressions.

FengXianGuo commented 5 years ago

Yeah, thanks for merging 😎

amireh commented 5 years ago

Released 5.0.1 on npm with the patch.