Open dreambear1234 opened 4 years ago
Hi,
Thanks for your interest in our work and your detailed questions. It should be noted that currently we are not doing fully quantized model since a fully quantized model needs to match specific hardware details which may vary significantly across CPUs, GPUs or FPGAs. As a general quantization method, we believe model size is important to the memory bottleneck and multiplications are the main part of the computation, so we tried to compress all weights in a neural network and make all the multiplications performed in low-precision. Please see the detailed answers below:
(b) After adding the result of the third convolution to the result from the other branch, the final results will be passed to ReLU6 and then quantized after ReLU6
I think there is no ReLU6 append after elementwise addition in mobilenetv2. Quantization might be lost as @dreambear1234 said.
Any more comments?
Thanks for the nice paper. I am assuming this is not the complete code of the paper? All of the things @dreambear1234 said are still valid and a concern.
@yaohuicai, how are you doing multiplications in low-precision? Based on this code ( https://github.com/amirgholami/ZeroQ/blob/master/classification/utils/quantize_model.py#L45 ) , only acts after ReLU is quantized and you lose quantization on Conv and FC layers. I guess your answer to Q3 is simply not correct. We have tried it and fused BN is affecting the accuracy in quantized models considerably.
Please update us on whether there is an updated code available, otherwise, I believe this code won't give a fair comparison against other methods. We are planning to move only the distillation
code to the distiller framework, have the proper quantization on activations, do batch norm folding, etc.
Great job, you give the best quantization accuracy as I know. I'm very interested in your paper and code, but I have some issue about this paper. As far as my knowledge. For a full quantized model, all tensor&weight&bias should be quantized.
from your code, I get some question.
bias is not quantized earlier. use scale_bias = scale_input scale_weight maybe useful(some difference between float and int8 exist), but if bias value bigger than scale_bias128(for int8 mode), this error will be very large. Don't you care about it ?
input/output tensor quantize is not enough in your model. Did you use "QuantAct" as input/output quantize? from https://github.com/amirgholami/ZeroQ/blob/master/utils/quantize_model.py#L46 only tensor after relu/relu6 are quantized. for mobilenet-v2 network, a. you lose quantization for first input quantization; b. In every Bottleneck, the third convolution has no relu/relu6, quantization is lost; c. all bypass add structure has no quantization. so add cannot run as a quantize operation.
BatchNorm should be fused with convolution ? In most cnn engine, batchnorm is fused in convolution or fully_connect before inference, so it is necessary to fuse batchnorm with conv/fc before quantization. I have no idea whether final accuracy will increase or decrease after fuse.
Act_max and Act_min values ? According to my test(for model mobilenet-v2), after https://github.com/amirgholami/ZeroQ/blob/master/uniform_test.py#L89 all Act_max is 6, all Act_min is 0, it is just the range of relu6, for most other method who calculate act_min&act_max value, 0 & 6 is the most common case, I didn't find any difference from result.
Thank you for your reply.