search

amirhoseinsalimi / programmer-fa

Programmer Farsi - A bot that brings tweets about programming to your feed.
https://twitter.com/programmer_fa
MIT License
80 stars 14 forks source link

Setup GitHub Actions for CD #58

Open amirhoseinsalimi opened 2 years ago

shywn-mrk commented 2 years ago

I would be happy to contribute. Can you provide me with more information about it?

amirhoseinsalimi commented 2 years ago

Wow. I've just opened this. How did you find this repo so quickly?

I just want to setup auto-deployment for this project, so whenever a commit is made to the master branch, it gets deployed on the production server.

I think one of the key points here is going to be tests, so I should write more tests to be more confident.

Now, what is your opinion about this? What should we do before making this happen?

shywn-mrk commented 2 years ago

Having tests such as unit tests can be checked before deploying to production. A simple CI/CD for this project can be written in a short amount of time but I need more details. Writing tests, however, is not related to the pipelines. Our concerns should be separated.

amirhoseinsalimi commented 2 years ago

I agree. I don't have much knowledge to create an action script for GitHub actions. Could you write one? (Time is not a concern, just asking)

amirhoseinsalimi commented 2 years ago

I forgot something. What kind of information do you need? Getting started with the project is already documented in the README. What else do you need?

shywn-mrk commented 2 years ago

Where should we exactly deploy? The runners should be configured.

amirhoseinsalimi commented 2 years ago

On my personal server. How can we co-operate?

shywn-mrk commented 2 years ago

Currently, I'm on vacation but we can have a meeting. I will contact you next week.

MiKDev commented 2 years ago

I would be happy to contribute if this issue still exists.

amirhoseinsalimi commented 2 years ago

Thanks. Going to merge.