search

amirr-dotcom / custom_searchable_dropdown

Apache License 2.0
4 stars 8 forks source link

initialIndex is NOT an initialIndex, but a selectedItemIndex #3

Open evanholt1 opened 3 years ago

evanholt1 commented 3 years ago

going by the example as in https://pub.dev/packages/custom_searchable_dropdown/example, i tried to set an initialIndex, as a starting value for the menu. doing so, however, made the value never change when i select a different option from the dropdown.

i.e: if you give an initialIndex of 2 to the dropdown, the dropdown's visible value will NEVER change, even when using setState(). the dropdown does not redraw when an initialIndex is chosen, except if the initialIndex is changed. the newValue is given to onChanged, but the visible value is ALWAYS the value of the initialIndex.

this means initialIndex should be always now set to the index of the SELECTED VALUE, which is quite confusing and seems wrong..

amirr-dotcom commented 3 years ago

Thankyou for the suggestion i will definatetly change it as soon as possible. Thankyou for providing your feedback its very helpful for making custom searchable drop down better. Thankyou

On Sat, 9 Oct, 2021, 1:40 pm Osama Chegem, @.***> wrote:

going by the example as in https://pub.dev/packages/custom_searchable_dropdown/example, i tried to set an initialIndex, as a starting value for the menu. doing so, however, made the value never change when i select a different option from the dropdown.

i.e: if you give an initialIndex of 2 to the dropdown, the dropdown's visible value will NEVER change, even when using setState(). the dropdown does not redraw when an initialIndex is chosen, except if the initialIndex is changed. the newValue is given to onChanged, but the visible value is ALWAYS the value of the initialIndex.

this means initialIndex should be always now set to the index of the SELECTED VALUE, which is quite confusing and seems wrong..

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/amirr-dotcom/custom_searchable_dropdown/issues/3, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQ664NW3463AEKC64LXTNK3UF72FVANCNFSM5FVAXJIA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

junaidgoharhashmi commented 2 years ago

i am also facing the same issue. do you still working on it?