amirzaidi / Launcher3

The Launcher3 fork known as "Rootless Pixel Launcher"
Other
3.83k stars 642 forks source link

Hide apps and per app icon change (Request) #472

Open gcladores opened 6 years ago

gcladores commented 6 years ago

Hide apps and per app icon change from internal storage.

amirzaidi commented 6 years ago

Hiding apps is already in the launcher

gcladores commented 6 years ago

Yeah you're right. Sorry bout that. I was looking for it in the settings. What about force round icons?

SANJAYSKIM commented 6 years ago

How to hide?? In v3.5, app long press not showing options for this

amirzaidi commented 6 years ago

@gcladores force round icons is always enabled, legacy icon masking is disabled

gcladores commented 6 years ago

Google News and Weather, Google Chrome. VLC and other apps won't force round. google chrome has the white border. looks better when its just the chrome icon no white border. when I use Rootless Pixel 2 Launcher v4.0.3 from paphonb. the all have rounded icons. i switched because i don't like the pixel launcher android p dev preview

screenshot_20180424-021106 screenshot_20180424-021114

gcladores commented 6 years ago

using Google Nexus 6P unrooted. Stock Android 8.1. from OTA. Substratum Themed.

amirzaidi commented 6 years ago

Substratum or any other OMS theme engine breaks the round icon extraction due to Android limitations

wrick17 commented 6 years ago

I am not able to hide apps in the app drawer.

perceival commented 6 years ago

Hiding apps works. You need to long press icon in the drawer and choose a pencil. I was switching from another implementation of Pixel Launcher where there was an option in settings for it. However... now how can I unhide the app?

SANJAYSKIM commented 6 years ago

Long press not showing pencil icon

perceival commented 6 years ago

I can say for Oreo only. Not sure which version you have.

wrick17 commented 6 years ago

Hi, I'm on Oreo, long press does not get me the pencil icon. Only got the info icon.

gcladores commented 6 years ago

you have to have a icon pack installed and you have to use it in the launcher. took me a while to figure that one out too

perceival commented 6 years ago

Indeed. And reverting to system default icon pack unhides all the hidden apps as well.

wrick17 commented 6 years ago

@gcladores and @perceival that was the trick. Finally got it to work. Thank you.

lexabug commented 6 years ago

However... now how can I unhide the app?

Yeah, I would like to know too!

amirzaidi commented 6 years ago

Search in the app drawer

gcladores commented 6 years ago

Resolved my icon problem. I made a custom icon pack for the ones i'm missing using Iconstrutor and Apk Editor Pro. Apk Editor doesn't work on my Nexus 6P. Because it's not rooted. i had to transfer the apk form Iconstrutor to my Nexus 5 then back to 6P

gcladores commented 6 years ago

Would still love to have a per app icon change though. So i can change it straight from my Device storage

mzuverink commented 6 years ago

Why can you not offer the option of not forcing round icons? Nice launcher, makes my icons look like hell though. Im not using your launcher to mimic the look of some other device,Im here for the functionality. The option to not force round icons... Forcing round icons doesnt even 100% work. Please offer the option in settings.

GeekyBoyHT commented 6 years ago

You all are forgetting about - 'per app icon change from internal storage.' Please so something about that.

pgaskin commented 6 years ago

@amirzaidi Is there a reason why you only allow hiding apps when a custom icon pack is used? The only things I see which block hiding apps with the system icon pack are:

https://github.com/amirzaidi/Launcher3/blob/1e29b1073c1bcdb12931d3c253c7290596b62f56/src/com/google/android/apps/nexuslauncher/CustomAppFilter.java#L28-L31

https://github.com/amirzaidi/Launcher3/blob/1e29b1073c1bcdb12931d3c253c7290596b62f56/src/com/google/android/apps/nexuslauncher/CustomEditShortcut.java#L19

The only reason I see is because it overrides NexusAppFilter, which hides a few apps: https://github.com/amirzaidi/Launcher3/blob/1e29b1073c1bcdb12931d3c253c7290596b62f56/src/com/google/android/apps/nexuslauncher/NexusAppFilter.java#L11-L23

So, is there a reason why the check for CustomEditShortcut can't be removed and then change CustomAppFilter to:

public boolean shouldShowApp(ComponentName componentName, UserHandle user) {
    if (CustomIconUtils.usingValidPack(mContext)) {
        return !isHiddenApp(mContext, new ComponentKey(componentName, user));
    }
    return super.shouldShowApp(componentName, user) && !isHiddenApp(mContext, new ComponentKey(componentName, user));
}

This way, apps would be able to be hidden, but when using an icon pack, the system apps which are hidden by default will be able to be shown (like the behavior is right now).

amirzaidi commented 6 years ago

@geek1011 because I initially wanted to offer a toggle to enable/disable the Preferences option for people that do not want it, but I didn't want to have to translate it to ~60 languages so I decided to connect it to the icon pack implementation. I now realize it was a stupid idea, and I will definitely not do it like this in the future, but many people are used to it as it is. There is additional logic connected to it - when the icon pack is disabled, the default NexusAppFilter is used, and when it is enabled, icon packs are hidden to reduce app drawer clutter. Good ideas in my head, confusing UX in practice.

Hanif-abuvani commented 5 years ago

Lawn chair's implementation for hide app is perfect.