search

amis92 / RecordGenerator

C# immutable records generator
https://amis92.github.io/RecordGenerator/
MIT License
72 stars 10 forks source link

Use camelCase instead of PascalCase parameter names #57

Closed atifaziz closed 5 years ago

atifaziz commented 5 years ago

The naming convention in .NET for parameters is to use camel case (fooBar) but the generator uses Pascal case (FooBar) like properties do.

I'd be happy to submit a PR to fix this if it would be welcome.

amis92 commented 5 years ago

Well, yeah. A PR will be welcome, definitely. I'd like to keep it super-simple, so lower-casing the first character.

Also, this PR will need as a pre-requisite the #28. Can you do that as well?

atifaziz commented 5 years ago

Also, this PR will need as a pre-requisite the #28. Can you do that as well?

I'm afraid I am not familiar with analyzers so it might take me more time. I can try but otherwise should this stall until #28 is done? Or can I still submit a PR for this and you merge once #28 is done? Thinking how we can avoid a waterfall approach here.

amis92 commented 5 years ago

Sure, go on with this, and I'll add the analyzer to your PR maybe, so remember to check "allow contributor to make changes" or something when opening PR.

amis92 commented 5 years ago

Although feel free to try the Analyzers yourself, it's not so hard and quite fun :D

atifaziz commented 5 years ago

Although feel free to try the Analyzers yourself, it's not so hard and quite fun :D

Sounds like a great opporunity to do this together using VS Live Share if it's not hard and it would certainly be a fun experience. 😉

amis92 commented 5 years ago

That'd be great! Do you use gitter or other platform with PMs so we can agree on timeframe and other details?

atifaziz commented 5 years ago

That'd be great!

Awesome!

Do you use gitter…

Yes, I do!