Use the more conventional camel case for generated parameters

amis92 / RecordGenerator

C# immutable records generator

https://amis92.github.io/RecordGenerator/

MIT License

72 stars 10 forks source link

Use the more conventional camel case for generated parameters #59

Closed atifaziz closed 5 years ago

atifaziz commented 5 years ago

This PR fixes issue #57.

atifaziz commented 5 years ago

Also, please add Changelog entry :)

Done with 5506650b338b07abfc8249b39a973e13a2034a55.

amis92 commented 5 years ago

I'm in the middle of changing CI (appveyor->azure pipelines), so please hold on, I'll merge it when the move-over is done.

atifaziz commented 5 years ago

…so please hold on…

Meanwhile, wanted to say thanks for all your prompt reviews. It's fun working on a project where the maintainer is super responsive and detail-oriented.

atifaziz commented 5 years ago

Seems like you got the tests sorted out with 6430ed6d953514b5af26f8af655f39d0978a757c so I merged with master and the tests are passing (including on AppVeyor)! 🎉

amis92 commented 5 years ago

Follow-up for #28 (analyzer asserting property names are case-insensitive different, e.g. no properties like Count and count exist for a given record type - that'd mess up the methods like Update, or constructor) in a separate PR.