amis92 / RecordGenerator

C# immutable records generator
https://amis92.github.io/RecordGenerator/
MIT License
72 stars 10 forks source link

Single property optimizations #86

Closed megakid closed 5 years ago

amis92 commented 5 years ago

The styling is a matter of preference. I'd like to keep this project coherent, formatting-wise as well. Which means, please keep the style uniform, same as in other source files.

That said, I don't find a lot of line breaks helping - on the contrary, it divides lines into blocks, silently hinting about some separation. And separation means to me - maybe that's another method? So if you feel a need to separate things, refactor the block to a new method. (An exception to this rule is in unit tests, where line breaks naturally separate the three As of Arrange-Act-Assert).

Style wise, in terms of formatting complicated invocation trees:

That's how this project formats source code.

megakid commented 5 years ago

Understood - feel free to edit this PR to your own style. If the style was explicitly written somewhere or enforced via .editorconfig you may have a better chance of keeping the formatting clean without the frustrating back-and-forth over small formatting issues.

megakid commented 5 years ago

Wrong button

amis92 commented 5 years ago

feel free to edit this PR to your own style

This is probably for the best then.

.editorconfig is on todo, however it wouldn't help much for those issues.

amis92 commented 5 years ago

Thanks!