search

amisepa / BrainBeats

The BrainBeats toolbox, implemented as an EEGLAB plugin, allows joint processing and analysis of EEG and cardiovascular signals (ECG/PPG).
GNU General Public License v3.0
5 stars 4 forks source link

Do not remove ECG and add events to EEG structure #17

Closed arnodelorme closed 9 months ago

arnodelorme commented 1 year ago

It is drastic to remove the ECG channel. Instead keep it by default. Also add the ECG peaks as EEGLAB events.

amisepa commented 1 year ago

Which mode? It is preserved for removing heart components from EEG data. It is separated into its own structure for HEP and features.

I'm thinking of adding the option to keep or remove the ECG channel in GUI and users can choose.

It's necessary to remove it for HEP analysis, otherwise you have ECG signal in your ERP or time-frequency outputs.

What do you mean by eeglab events? We already have the heartbeats marked as R-peaks in the EEG data (HEP mode).

arnodelorme commented 1 year ago

It would be great if people could run the HEP and HRV modes at the same time. Not a super big deal, but definitely a limitation.

amisepa commented 1 year ago

Ok, that shouldn't be too hard to change that.

amisepa commented 9 months ago

Tricky to run both because of how the toolbox is designed: The EEG preprocessing are slightly different between HEP and features-mode. And for Features, you don't need the ms time synchrony between ECG/PPG and EEG, whereas it is essential for HEP. And HEP and Features are kind of very different applications so not sure it is worth the extra work at the moment.

I added the option to keep the cardiovascular channels via GUI and command line though.