amishmm / php-pam

This extension provides PAM (Pluggable Authentication Modules) integration for PHP
Other
10 stars 5 forks source link

Invalid value of xmlns:xsi attribute in package.xml #9

Closed mlocati closed 3 years ago

mlocati commented 3 years ago

We have this attribute of the root package element:

xmlns:xsi="http://www.w3.org/2001/XMLSchema- instance"

This is wrong. The correct value is

xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

(please remark that removed empty space between XMLSchema- and instance).

See https://www.w3.org/TR/2001/REC-xmlschema-1-20010502/structures.xml#Instance_Document_Constructions

amishmm commented 3 years ago

Thanks it will be fixed in next release. (Its already committed in master)

I do not think it makes any difference w.r.t the code. I am not an XML expert or PECL package expert. I just copy-pasted from the original unmaintained package.

Let me know if anything else is wrong. Thank you

mlocati commented 3 years ago

The problem is that the XML is malformed with that wrong namespace. When loading it we have this warning:

xmlns:xsi: 'http://www.w3.org/2001/XMLSchema- instance' is not a valid URI in Entity

See https://3v4l.org/L8750