search

amit-davidson / Chronos

Chronos - A static race detector for the go language
MIT License
424 stars 11 forks source link

golangci-lint #45

Closed jerome-laforge closed 2 years ago

jerome-laforge commented 2 years ago

Is it possible to be more friendly with golangci-lint with https://golangci-lint.run/contributing/new-linters/?

ayushr2 commented 2 years ago

See https://golang.org/doc/effective_go#package-names for package names and file names.

ayushr2 commented 2 years ago

The codebase seems to be using CamelCase for file names and package names.

amit-davidson commented 2 years ago

@ayushr2 It is, but it's not related. Chronos isn't friendly with golangci-lint as it doesn't support the go/analysis package. Supporting it is possible but too complex. More importantly, Chronos was written for learning purposes and isn't suitable for production use. Therefore, I don't recommend including it in golangci-lint

jerome-laforge commented 2 years ago

Thanks @amit-davidson for this information.