amit-schwartz-u / rooMe

Apache License 2.0
0 stars 5 forks source link

Suggestion: Organize your code in meaningful directories structure #170

Closed asaf-kali closed 4 years ago

asaf-kali commented 4 years ago

First - nice project! My suggestion is not product-related, but code related. Take a look at the code scturcture: image It would be much easier both for you and for somone new joining the project, if the classes were organized into directories with short and meaningful names. Preferably, the basic models would sit in one directory, activities in another, and fragments or adapters divided into some catagorised folder structure. A good thumb rule can be to organise it such that no folder contains more then 5 classes.

asaf-kali commented 4 years ago

Maybe something like that: image

Of couse this needs more thinking from someone who really knows the project, but it's a nice start. It is also always good to seperate the models the application uses, it's logical parts, and it's actual views implementation (from a quick look in the code, im not sure which class is which, but you guys will probably do it quickly).

ShaharBirzon commented 4 years ago

that's a great idea, we actually didn't organize it that well. We are planning to take your advice about that, with small differences of naming and hierarchy. Thank you!

ShaharBirzon commented 4 years ago

done!