search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

Delete user memberships when a group is deleted #179

Closed pfrenssen closed 8 years ago

pfrenssen commented 8 years ago

Here is an implementation for issue #176. We should clean up the memberships of users that are members of a group when the group is deleted.

This depends on PR #162.

pfrenssen commented 8 years ago

Now that #176 is in this is ready for review.

amitaibu commented 8 years ago

This on the fly approach might be problematic if we have lots of users.

Why not delegate this deletion to the a OgDeleteOrphans plugin?

amitaibu commented 8 years ago

(which will also be more consistent with OG7)

pfrenssen commented 8 years ago

Note that this will have a minor merge conflict with https://github.com/amitaibu/og/pull/189 - I'll take care of it in case that issue would be merged in first.

amitaibu commented 8 years ago

Needs a re-roll :)

pfrenssen commented 8 years ago

Rerolled!

amitaibu commented 8 years ago

Thanks!