amitaibu / og

A fork to work on OG8

https://github.com/Gizra/og

29 stars 16 forks source link

OgMembership extends OgMembershipInterface #186

Closed RoySegall closed 8 years ago

RoySegall commented 8 years ago

183

RoySegall commented 8 years ago

@amitaibu Ready for another look.

pfrenssen commented 8 years ago

Great stuff!

RoySegall commented 8 years ago

Great stuff!

10x.

RoySegall commented 8 years ago

@amitaibu @pfrenssen Pushed a couple of more fixes.

amitaibu commented 8 years ago

I think there are a few more comments that need to be addressed

amitaibu commented 8 years ago

I have revised a bit the OgMembership explanation - thank you @RoySegall for a good base to start from. In fact I think it's a valuable info, so I've copied to the README as-well.

Waiting for Travis to return green, and then it will be ready for review.

amitaibu commented 8 years ago

Let's get this in. We can revisit the README part also later.