Create a RoleManager service

amitaibu / og

A fork to work on OG8

https://github.com/Gizra/og

29 stars 16 forks source link

Create a RoleManager service #221

Closed pfrenssen closed 8 years ago

pfrenssen commented 8 years ago

Currently the GroupManager service is taking up too many responsibilities and has become a little overweight as a result.

We should refactor the methods related to managing roles into a separate RoleManager service:

createRoles()
getDefaultRoles()
removeRoles()

pfrenssen commented 8 years ago

@amitaibu, do you think it would be a good idea to create a new "Novice" label and attach it to this issue? If we can identify some low hanging fruit as easy fixes this might help to lure new contributors.

amitaibu commented 8 years ago

Novice label added!

pfrenssen commented 8 years ago

This is currently blocked by https://github.com/amitaibu/og/pull/192 but that is near completion.

amitaibu commented 8 years ago

This is in https://github.com/Gizra/og/blob/02cb66ce93ed710c62dfa87110e41f8c5af0d723/src/OgRoleManager.php