OgMembership::getUser always returns NULL

amitaibu / og

A fork to work on OG8

https://github.com/Gizra/og

29 stars 16 forks source link

OgMembership::getUser always returns NULL #233

Closed damiankloip closed 8 years ago

damiankloip commented 8 years ago

~~Will add the start of OgMembershipTest too.....~~

There are two main problems:

The getUser() method return $field_item->value which will not load the user, or ever return anything.
The base field definition configuration is wrong, so a user will not get loaded from a correctly set target_id.

damiankloip commented 8 years ago

@amitaibu here is some test coverage too. This new OgMembershipTest class can also be easily be extended to test other/new stuff as needed.

damiankloip commented 8 years ago

@amitaibu had to fix a few of the tests that were creating groups with no owner (tut tut :p) and thus failing the validation rom the owner membership creation we have in og_entity_insert.

damiankloip commented 8 years ago

@pfrenssen thanks for taking a look, your feedback should also be addressed.

pfrenssen commented 8 years ago

Great job, this looks good to me!

catch56 commented 8 years ago

Looks good here as well.

amitaibu commented 8 years ago

Great, thanks.