search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

Remove auto-prefixing on save since this prefixes already-prefixed ro… #235

Closed catch56 closed 8 years ago

catch56 commented 8 years ago

…le entities during configuration import.

This doesn't yet re-add the prefixing anywhere. Could do that in the form maybe? Or add validation to stop duplicates being created?

pfrenssen commented 8 years ago

There is an issue about this: https://github.com/amitaibu/og/issues/216. A possible way to fix this is proposed in that issue. We can set a 'name' that can be used to construct the ID on save.

pfrenssen commented 8 years ago

@catch56 in https://github.com/amitaibu/og/pull/217#issuecomment-225639354 @amitaibu proposed to let GroupManager::getDefaultRoles() to return partially populated OgRole objects instead of arrays. I am going to implement that now. In order to make that work I need to fix this issue with the prefixing on save too.

I'm going to work on that now. Just so you know that this is going to be addressed shortly, and we won't do duplicate work. I'll link the PR as soon as I got something.

pfrenssen commented 8 years ago

A proposed fix is included in #237. Closing this as a duplicate.