search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

Workaround for core bug #2752315 #241

Closed pfrenssen closed 8 years ago

pfrenssen commented 8 years ago

Core issue #2735199: Convert web tests to browser tests for help module which was merged this weekend introduced a new legacy assertion method assertNoEscaped() in browser tests, but this has the wrong visibility. This currently causes our tests on 8.2.x to break with the following error message:

PHP Fatal error: Access level to Drupal\simpletest\AssertContentTrait::assertNoEscaped() must be public (as in class Drupal\Tests\BrowserTestBase) in /home/travis/build/amitaibu/og/og_ui/tests/src/Functional/BundleFormAlterTest.php on line 24

A fix is proposed in #2752315: Fix visibility of AssertLegacyTrait::assertNoEscaped() but this has not been reviewed yet.

This PR temporarily works around the problem so we can continue working on OG.

This is very similar to the failure we had in #223.

amitaibu commented 8 years ago

👍 Also @RoySegall came across this in one of his PRs.

I'll merge when green.

pfrenssen commented 8 years ago

Not needed any more, the upstream patch is merged. Closing.