amitaibu / og

A fork to work on OG8

https://github.com/Gizra/og

29 stars 16 forks source link

Special permission 'update group' handle #250

Closed idimopoulos closed 8 years ago

idimopoulos commented 8 years ago

246

After the discussion in https://github.com/amitaibu/og/pull/240 and while the permission integration is being built in a few pull requests (most of which are already merged in), the special permission handling 'update group' has not been implemented yet.

This ticket will add a simple check to properly map the permission passed as operation to the OgAccess::userAccess method to the appropriate special permission.

A simple functional test will be included as well in order to test the usability of the code.

amitaibu commented 8 years ago

What's the status here, ready for review? 😄

idimopoulos commented 8 years ago

Yes! I think I don't have access to set it myself! Or I am too noob to find it out :D

amitaibu commented 8 years ago

Needs a re-roll

idimopoulos commented 8 years ago

Re-rolled. (if that means 'merge in latest changes'.) :D

idimopoulos commented 8 years ago

@amitaibu is the error valid? Only happens in one instance out of 6 and it is a timeout.

Edit: Not that I see it, it's not even in the files I changed :/

amitaibu commented 8 years ago

I have restarted that Travis test.

amitaibu commented 8 years ago

Thanks!

idimopoulos commented 8 years ago

Thank You :) :) My first commit :D :D :D