search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

Adding code sniffer. #251

Closed RoySegall closed 8 years ago

RoySegall commented 8 years ago

249

RoySegall commented 8 years ago

@amitaibu We got the code sniffer in the travis and the tests are failing. I pushed automatic phpcbf fixes but the indentation seem wrong to me: oguieventsubscriber_php_-_phpstorm_10_0_3

amitaibu commented 8 years ago

but the indentation seem wrong to me:

Maybe it gets confused from those long arrays. I know I get confused by them. Can you try to manually break down one of those arrays and see if the sniffer nows how to work with them. I'd like to get this one in, as it provides a nice way for code consistency.

amitaibu commented 8 years ago

Alright, lets give this one some love, so we can start working on a "clean" OG.

amitaibu commented 8 years ago

Current status after the auto-fixes:

og_ _amitai_amitais-macbook-pro_ _zsh_ _112x33

need to roll our sleeves... 😉

amitaibu commented 8 years ago

Fixes are easy, we should be able to get it done in a couple of hours..

@RoySegall if you are around and care to join the (sad) party, you can start from top, and I'll continue my work for the bottom. 😉

RoySegall commented 8 years ago

I'll try to cover this one in the contribution hours in this week.

amitaibu commented 8 years ago

tests are now error free. Not too much left.

RoySegall commented 8 years ago

@amitaibu I'm managed to add the git hook for running the sniff each commit. If you'ld like to skip it just add [skip sniff] in the commit message.

Or should I hold with this one?

amitaibu commented 8 years ago

@RoySegall lets do it in another PR, this one is already big.

Anyway, I was just able to finish the last error!

og_ _amitai_amitais-macbook-pro_ _zsh_ _112x33

The two remaining warnings (not errors) are related to tests

amitaibu commented 8 years ago

Seems the warning are failing the tests as-well. Lets see if we can work around it.

amitaibu commented 8 years ago

Seems some tests are off, I'm on. Going to get this monster in soon! 😄

amitaibu commented 8 years ago

Seems og.views.inc was deleted upon creation of the PR. I've re-added it.

amitaibu commented 8 years ago

Ready for review! Are you brave enough to go over the 85 files changed.. 👻

amitaibu commented 8 years ago

Lets get this in, so any subsequent PR will already be coder aware.

pfrenssen commented 8 years ago

Great job!!!!