search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

Improve OgMembership Create DX #254

Closed amitaibu closed 8 years ago

amitaibu commented 8 years ago

We now have:

$membership = OgMembership::create(['type' => OgMembershipInterface::TYPE_DEFAULT]);
$membership
  ->setUser($user->id())
  ->setEntityId($group->id())
  ->setGroupEntityType($group->getEntityTypeId())
  ->save();

but we could improve this (confusingly named) setEntityId and setGroupEntityType and have SetGroup($group) instead. Also those method should get the full object not just the ID:

$membership = OgMembership::create(['type' => OgMembershipInterface::TYPE_DEFAULT]);
$membership
  ->setUser($user)
  ->setGroup($group)
  ->save();
amitaibu commented 8 years ago

Also setting the roles can get an array of roles objects not just Ids:

->setRoles([$og_role->id()])

Would become:

->setRoles([$og_role1])
amitaibu commented 8 years ago

I'll take this one.