search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

Create membership DX followup #261

Closed pfrenssen closed 8 years ago

pfrenssen commented 8 years ago

This is a followup of PR #258 - we can improve DX even harder :D

pfrenssen commented 8 years ago

I also ran PHP CodeSniffer on OgMembership and OgMembershipInterface and fixed all warnings.

pfrenssen commented 8 years ago

This single failure in the last commit was because OgMembershipReferenceItemList was creating a new OgMembership entity through a dedicated helper function instead of using OgMembership::create().

I have changed it so it is consistent throughout the entire codebase. I've also removed that helper method Og::membershipStorage(). I don't think this has much value for a D8 developer, it's only a few characters less to type than $this->entityTypeManager->getStorage(), and this is something which everyone immediately recognizes.

amitaibu commented 8 years ago

Tiny comment. Rest looks great

amitaibu commented 8 years ago

I'll get this one in, after I'll merge #251 (i.e. tomorrow)

amitaibu commented 8 years ago

Needs a re-roll (I preferred to get the coder in, as I realized there will most probably be merge conflicts with this one).

pfrenssen commented 8 years ago

Rerolled, addressed remark, added some random out of scope documentation fixes :strawberry:

amitaibu commented 8 years ago

phpcbf should be your friend here :)

pfrenssen commented 8 years ago

Hahaha caught red handed!!! Really nice to have this automatically checked now. I'll have a look to fix these during my lunch break.

I'll also make a followup to have this coding standards check available locally as a dev-dependency. Then we can easily run the coding standards check before pushing.

amitaibu commented 8 years ago

no worries, I've ran phpcbf on your branch and pushed. coder should be fixed now.

amitaibu commented 8 years ago

Travis seems to be stuck :/

amitaibu commented 8 years ago

Oh, actually it's finally running!

amitaibu commented 8 years ago

Thanks!