Add more validation to membership creation

amitaibu / og

A fork to work on OG8

https://github.com/Gizra/og

29 stars 16 forks source link

Add more validation to membership creation #267

Closed amitaibu closed 8 years ago

amitaibu commented 8 years ago

Check group is set
Check group is a valid "group" type

amitaibu commented 8 years ago

Failing tests reveal some bugs in our tests, so validation is working.

amitaibu commented 8 years ago

I'm going to set it to needs review and open up a follow up to possibly move it later to Contraints. I think it's more important to get something working in, and possibly polish it later.