Add Og::getRole helper method

amitaibu / og

A fork to work on OG8

https://github.com/Gizra/og

29 stars 16 forks source link

Add Og::getRole helper method #274

Closed amitaibu closed 8 years ago

amitaibu commented 8 years ago

Split out of #268

amitaibu commented 8 years ago

PR also adds the missing OgRoleInterface::getId()

amitaibu commented 8 years ago

Ready for review

jhedstrom commented 8 years ago

This makes sense to me, does it make sense to test in one of the existing tests?

amitaibu commented 8 years ago

does it make sense to test in one of the existing tests?

It does. I'll add one.

amitaibu commented 8 years ago

Obviously adding the one liner test found a bug in my code :) And then I realized there's a simpler way to write the method - it's just a wrapper over OgRole::load().

jhedstrom commented 8 years ago

👍