Allow unsubscribing a pending membership

[amitaibu]

\Drupal\og\OgAccess::userAccess should check unsubscribe permission even if membership is pending

[pfrenssen]

Do you think there will ever be any more permissions a pending member could have? For example a group could allow pending members to start interacting with a certain section of the group - to introduce themselves to the group for example.

I'm asking because it would be a different implementation:

• If pending member can only be unsubscribing and nothing else, this will be a hard coded switch where we check this particular permission and give access accordingly.
• If potentially more permission can be granted, we can provide a column for the "pending" role in the UI. 'unsubscribe' would be checked by default, but the admins can also decide to grant other permissions. Or even deny pending members from unsubscribing.

I personally think the UI option would be more flexible, and easier to implement and test too :)

[amitaibu]

We should take the simple route here and special case just the unsubscribe. Meaning - hardcoded switch.

On Aug 5, 2016 10:33 AM, "Pieter Frenssen" notifications@github.com wrote:

Do you think there will ever be any more permissions a pending member could have? For example a group could allow pending members to start interacting with a certain section of the group - to introduce themselves to the group for example.

I'm asking because it would be a different implementation:

• If pending member can only be unsubscribing and nothing else, this will be a hard coded switch where we check this particular permission and give access accordingly.
• If potentially more permission can be granted, we can provide a column for the "pending" role in the UI. 'unsubscribe' would be checked by default, but the admins can also decide to grant other permissions. Or even deny pending members from unsubscribing.

I personally think the UI option would be more flexible, and easier to implement and test too :)

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/amitaibu/og/issues/283#issuecomment-237777360, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHrC3v9FqrXsU_IWWzxi5sQOMDAuBgLks5qcudNgaJpZM4JbA6b .

[amitaibu]

For reference: We no longer have the unsubscribe permission. Instead we special case it and allow it in the unsubscribe logic