Create a dedicated RoleManager service

amitaibu / og

A fork to work on OG8

https://github.com/Gizra/og

29 stars 16 forks source link

Closed pfrenssen closed 7 years ago

pfrenssen commented 7 years ago

We currently have a number of methods in GroupManager which are not actually dealing with groups; they deal with OG roles:

::createPerBundleRoles()
::getDefaultRoles()
::getRequiredDefaultRoles()
::removeRoles()
Scope
1. Create the OgRoleManager service and move the 4 methods in there.
2. Create the OgRoleManagerInterface which documents the public methods in the service.
3. Tests should obviously pass :)

pfrenssen commented 7 years ago

@amitaibu do you agree this would be an improvement? Should it be called RoleManager or OgRoleManager?

amitaibu commented 7 years ago

Sounds great. I think OgRoleManager would be better.

pfrenssen commented 7 years ago

Great! I'll update the issue summary.

dakala commented 7 years ago

Hi @pfrenssen

I'd like to help with this issue please

dakala commented 7 years ago

Refactor done. Tests not passing yet

pfrenssen commented 7 years ago

@dakala thanks for picking this up! Looking forward to the PR! :)

amitaibu commented 7 years ago

Feel free to open PR even before it's complete - you might earn some early review :)