search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

WIP: Add OgRoleManager service #298

Closed dakala closed 8 years ago

dakala commented 8 years ago

First attempt at issue #295. At the moment a couple of the services injected in GroupManager.php look redundant to me.

GroupManagerTest still broken from the UI. Passing with php core/scripts/run-tests.sh --color --verbose --class "Drupal\Tests\og\Unit\GroupManagerTest

Thanks everyone!

amitaibu commented 8 years ago

Hi @dakala, what's the status here?

dakala commented 8 years ago

Sorry, it's the tests @amitaibu. Will take a look again and update issue with the status tomorrow

amitaibu commented 8 years ago

Great, thanks.

On Aug 15, 2016 4:21 PM, "Deji Akala" notifications@github.com wrote:

Sorry, it's the tests @amitaibu https://github.com/amitaibu. Will take a look again and update issue with the status tomorrow

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/amitaibu/og/pull/298#issuecomment-239799900, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHrCxpFkDRuIJEdIgiwbFF6llYvEUVrks5qgGfkgaJpZM4JeiOA .

dakala commented 8 years ago

Hi @amitaibu, @pfrenssen! Who can assist with my broken unit tests please? I think it's the mocking of config factory that's causing the problem in testAddGroupNew() and testRemoveGroup(). If someone can help or point in the right direction, that'd be great. Thanks!

amitaibu commented 8 years ago

Sure, I can have a look. Would be great if you could fix the PHPCS errors first (most of them can be fixed automatically with PHPCBF).

After that please ping, and I'll test it. I'm on vacation, so it might take me a few days to answer, though :)

dakala commented 8 years ago

@amitaibu thanks. I had to do the CS fixes manually - phpstorm had let me down :-) Enjoy your holiday!

amitaibu commented 8 years ago

Closed in favor of #145. I'll fix the tests there.