search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

Inject EntityTypeManager in the MembershipManager #308

Closed pfrenssen closed 7 years ago

pfrenssen commented 7 years ago

Now that we have the MembershipManager service, let's inject EntityTypeManager into it so we don't have to fall back to the static methods in \Drupal and are fully decoupled.

amitaibu commented 7 years ago

Makes sense. Tests are failing, though.

amitaibu commented 7 years ago

Oh, and can you open it again the main repo (on mobile so can't link the issue I opened this morning :)

pfrenssen commented 7 years ago

I found the issue: #307

Sure! I'll close this and reopen it there.

pfrenssen commented 7 years ago

Created PR in main repo: https://github.com/Gizra/og/pull/142