search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

BundleFormAlterTest to use browsertestbase #310

Closed dakala closed 7 years ago

dakala commented 7 years ago

First attempt at issue #305 - Convert BundleFormAlterTest to use the new BrowserTestBase

amitaibu commented 7 years ago

Looks good. Would you mind closing this one and opening a new PR against https://github.com/Gizra/og

amitaibu commented 7 years ago

Actually I'll just merge this one, and push upstream.

amitaibu commented 7 years ago

(after the minor comment will be fixed)

dakala commented 7 years ago

@amitaibu: Just noticed the earlier comment. Is it better to issue all PRs against Gizra/og? It might be better to change my upstream to that repo.

amitaibu commented 7 years ago

Yeah the Gizra/og is back to being the main repo.

On Aug 23, 2016 10:32 AM, "Deji Akala" notifications@github.com wrote:

@amitaibu https://github.com/amitaibu: Just noticed the earlier comment. Is it better to issue all PRs against Gizra/og? It might be better to change my upstream to that repo.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/amitaibu/og/pull/310#issuecomment-241650519, or mute the thread https://github.com/notifications/unsubscribe-auth/AAHrC3CZn9xl_OvO2F83givNj4sUdtgmks5qiqICgaJpZM4Jqhe9 .

amitaibu commented 7 years ago

Merged, thanks.