search

amitaibu / og

A fork to work on OG8
https://github.com/Gizra/og
29 stars 16 forks source link

UI functionality is scattered between OG UI and OG modules. #315

Open ArchieDoe opened 7 years ago

ArchieDoe commented 7 years ago

For example, group UI on node page (group tab) is rendered by OG module, when OG basic configs (like group type roles, permissions, etc.) are rendered by OG UI module.

Another reason is to avoid code duplication. For example, we have (or potentially have) 2 similar pages: roles overview on group type page and roles overview on specific group. To render this we basically need same code, but following current implementation it should be done in 2 separate places with different classes.

To me all UI (and adding routes) should not be accessible when UI module is disabled, as it happens with other modules, e.g. views UI or fields UI.

I suggest to move all UI related functionality, including OgAdminRoutesController and interface into OG UI module.

ArchieDoe commented 7 years ago

Also, decision on this part blocks me from finishing #196

amitaibu commented 7 years ago

Since in D8 code is better lazy loaded then D7 I wouldn't mind moving UI stuff to OG core.

ArchieDoe commented 7 years ago

Ok, so should we move OG UI into core then?

amitaibu commented 7 years ago

I think we can do that. @pfrenssen agree?

ArchieDoe commented 7 years ago

Yah, @amitaibu @pfrenssen, it might be a good idea to move it into main module. For example this Gizra#231, which is also UI PR, done inside of main module

amitaibu commented 7 years ago

Lets have a dedicated PR to do that.

pfrenssen commented 7 years ago

Sounds good to me.

MPParsley commented 5 years ago

@pfrenssen this issue could use a new title: "Remove OG UI module"

I think merging OG & OG UI makes sense, since the UI isn't just for admin purposes like for example Field UI -- it's for the actual interaction of end users with the group functionality. I think, however it should be done in a separate PR, to keep this one from being too big.

MPParsley commented 5 years ago

See @amitaibu 's remark in https://github.com/Gizra/og/pull/243#issuecomment-396493779