amitaymolko / react-native-rsa-native

A native implementation of RSA key generation and encryption/decryption.
MIT License
232 stars 112 forks source link

Improper key description in Readme file #159

Open RajatSatashiya opened 10 months ago

RajatSatashiya commented 10 months ago

This is the current description of the library: "A native implementation of RSA key generation and encryption/decryption, sign/verify. Keychain implementation Implementation is in PKCS1"

This however is wrong because although PKCS #1 is being generated for android, the key being generated for iOS devices is PKCS#8. Now, rather than changing the readme, you should update your code to generate PKCS #8 key for android devices as it is the industry standard and easy to verify from backend (JAVA, Node.js, etc...)